Use .tmpl to stop SDK refs trying to parse the template Cargo.toml #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: itowlson <[email protected]>
|
cc @karthik2804 |
fibonacci1729
approved these changes
Jun 26, 2024
karthik2804
approved these changes
Jun 26, 2024
radu-matei
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDK is currently only in GitHub. When Rust resolves a reference to the SDK, it scans the entire repo. In recent version of Rust, this chokes because there is a Cargo.toml in the templates directory and that is not a valid Cargo manifest. The workaround is to add the
.tmplextension, which recent versions of Spin know how to strip when installing the template.