-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aws): Fix AWS CLI v2 for Alpine Linux #6279
Conversation
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
Install a version using musl instead of glibc
a13f244
to
3a64809
Compare
@jervi would you mind updating the commit message + PR description a bit? Moving from |
I've updated the PR description |
Thank you! |
PS This fixes #6156. |
It's a little bold backporting this when it bumps alpine from 3.16 to 3.20, but since the aws cli is busted in alpine docker images in 1.35, I'ma do it. |
@Mergifyio backport release-1.35.x |
✅ Backports have been created
|
* fix(aws): Fix AWS CLI v2 for Alpine Linux Install a version using musl instead of glibc * Fix for legacy key/value format (cherry picked from commit 0226100)
* fix(aws): Fix AWS CLI v2 for Alpine Linux Install a version using musl instead of glibc * Fix for legacy key/value format (cherry picked from commit 0226100) Co-authored-by: Jørgen Jervidalo <[email protected]>
Included in Spinnaker 1.35.4. |
The version of the AWS CLI v2 that is currently installed in the
slim
docker images (Alpine based) does not work. Trying to execute the aws binary results in abash: /usr/local/bin/aws: No such file or directory
error, even though the binary is present. The error occurs because Alpine Linux doesn't supportglibc
. To fix this we need to install a version of AWS CLI v2 that is usingmusl
instead ofglibc
.Starting from Alpine 3.18, compatible aws-cli binaries are available in the official package repos, meaning we can just
apt add
it.I've bumped the version to the latest available for Alpine (2.15.57) and also bumped Alpine itself from 3.16 to 3.20 (since aws-cli v2 wasn't available in 3.16, and only 3.20 supports the newest version of aws-cli).