Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deployManifest): Adding Label Selectors feature support #10154

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

christosarvanitis
Copy link
Member

Adding support in the deployManifest stage for the Label Selectors features introduced in 1.35.x (see spinnaker/clouddriver#6220)

LabelSelectorDemo.mov

Copy link
Member

@jasonmcintosh jasonmcintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we need a feature flag & then backport to 1.35?

@christosarvanitis
Copy link
Member Author

Did we need a feature flag & then backport to 1.35?

@jasonmcintosh up to you? This #10152 goes under the same category and I didnt feature flag it. Do both under a single flag?

@christosarvanitis
Copy link
Member Author

@jasonmcintosh added a feature flag support for both configuration options

@jasonmcintosh jasonmcintosh added the ready to merge Reviewed and ready for merge label Nov 25, 2024
@mergify mergify bot added the auto merged Merged automatically by a bot label Nov 25, 2024
@mergify mergify bot merged commit 45bf17d into spinnaker:master Nov 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Reviewed and ready for merge target-release/1.37
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants