This repository was archived by the owner on Dec 20, 2025. It is now read-only.
feat(deploy/blockDevices): Adds a Volume section in the Deploy wizard#8911
Closed
jorgebee65 wants to merge 24 commits intospinnaker:masterfrom
Closed
feat(deploy/blockDevices): Adds a Volume section in the Deploy wizard#8911jorgebee65 wants to merge 24 commits intospinnaker:masterfrom
jorgebee65 wants to merge 24 commits intospinnaker:masterfrom
Conversation
…, this section allows to add multiple volumes to an instance, and also add Tags.
jorgebee65
changed the title
Contributor
|
This PR should use the |
…upConfiguration.service.ts Co-authored-by: Ian Delahorne <ian.delahorne@gmail.com>
…mFields and resolving conflicts
…ls, remove serverGroupCommandBuilder.service.ts
christopherthielen
suggested changes
Jul 22, 2021
Contributor
christopherthielen
left a comment
christopherthielen
left a comment
There was a problem hiding this comment.
thanks for migrating this to Formik. I have a couple minor requests then I think it's good to go.
Comment on lines
+61
to
+67
| <div className="form-group"> | ||
| <div className="sm-label-left"> | ||
| <b>Tags (optional)</b> | ||
| <HelpField id="aws.serverGroup.blockDevice.tags" /> | ||
| </div> | ||
| <MapEditor model={blockTags as any} allowEmpty={true} onChange={this.tagsChanged} /> | ||
| </div> |
Contributor
There was a problem hiding this comment.
This should use a FormikFormField and a MapEditorInput which would also make the validate and `tagsChanged functions unnecessary
Comment on lines
+22
to
+31
| public validate( | ||
| values: IBlockDevicesCommand, | ||
| ): FormikErrors<IBlockDevicesCommand> { | ||
|
|
||
| const errors = {} as any; | ||
| const { blockDevices } = values; | ||
| console.log(blockDevices) | ||
| return errors; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
I don't think this function gets called ever, and it is also a noop, so might as well remove it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature adds a Volume section in the Deploy Wizard which allows to add one ore more volumes to an instance and also add Tags which applies to the list of volumes. Dependency on this other PR