This repository was archived by the owner on Dec 20, 2025. It is now read-only.
fix(core/InsightMenu): Removes code that throws error in the console#9001
Closed
bbrina wants to merge 4 commits intospinnaker:masterfrom
Closed
fix(core/InsightMenu): Removes code that throws error in the console#9001bbrina wants to merge 4 commits intospinnaker:masterfrom
bbrina wants to merge 4 commits intospinnaker:masterfrom
Conversation
bbrina
force-pushed
the
fix-insight-menu-console-error
branch
from
423800d to
c40ff19
Compare
dogonthehorizon
approved these changes
Mar 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes
href="javascript:void(0)"from Button component.Some of the benefits:
<button>instead of<a>