fix(ssl): Removed unused deprecated okHttpClientConfig from retrofitConfig. #1082
Conversation
DanielaS12
changed the title
|
What config flags made fiat fail? |
|
@dbyron-sf there were no config changes, but simply a forgotten autowired class, that was not used. That messed up the bean instantiation order and it was not visible before. The failure appeared after bumping up the kork version b655872, specifically this commit in kork spinnaker/kork@a68c7f5 This change is paired with multiple commits in fiat, that omitted to clean the resource from RetrofitConfig. |
|
@DanielaS12 I don't see how spinnaker/kork@a68c7f5 is relevant -- it doesn't seem to mention OkHttpClientConfiguration. |
|
@dbyron-sf you are correct. I mentioned this commit because before the commit everything worked fine, after it the error started. My proposed changes, only remove an unused, deprecated autowire and fix the issue mentioned above. |
|
@dbyron-sf Can this be merged? |
|
It looks good to me. Considering that with this PR we do some cleanup (delete unused field) that is messing with the SSL configuration. |
|
@Mergifyio backport release-1.29.x release-1.30.x release-1.31.x |
✅ Backports have been created
|
|
The kork PR broke this b/c it changed the ordering of bean loading/dependency handling :( The lazy loading IN THEORY might have fixed this, but ... that's iffy. |
|
Last comment: MOST of the stuff in this class seems iffy config/usage wise. Most of the fields aren't used at this point (and most of this should be in kork anyways). It looks like the RetryingInterceptor bean generation is the main thing |
…onfig. (#1082) (#1092) (cherry picked from commit 75e3660) Co-authored-by: DanielaS12 <[email protected]>
…onfig. (#1082) (#1091) (cherry picked from commit 75e3660) Co-authored-by: DanielaS12 <[email protected]>
…onfig. (#1082) (#1090) (cherry picked from commit 75e3660) Co-authored-by: DanielaS12 <[email protected]>
This change removes unused deprecated class. Its instantiation caused fiat to fail when configuring SSL. Other then fixing an issue, the class was never used.
Tested on local environment on fiat 1.29.x, master and 1.30.x.
Before this change:
After the change: