feat(build): add fiat-integration module to exercise the just-built docker imageTest docker image #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to facilitate testing container startup
multi-arch with --load doesn't work, so add a separate step using the local platform to make an image available for testing. see docker/buildx#59
jvz
approved these changes
May 1, 2024
|
|
||
| private static final int REDIS_PORT = 6379; | ||
|
|
||
| private static final Logger logger = LoggerFactory.getLogger(StandaloneContainerTest.class); |
There was a problem hiding this comment.
I will continue requesting that new code use the Log4j API
There was a problem hiding this comment.
Sorry, I'm copying and pasting at this point. Old habits die hard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, add a healthcheck to the docker images.