Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing getSupportedTypes #26

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Implementing getSupportedTypes #26

merged 1 commit into from
Dec 4, 2023

Conversation

msmakouz
Copy link
Member

This is required since SF 6.3 (deprecation warning)

@msmakouz msmakouz added the bug Something isn't working label Jun 10, 2023
@msmakouz msmakouz requested a review from butschster June 10, 2023 17:36
@msmakouz msmakouz self-assigned this Jun 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.44 🎉

Comparison is base (f95e2c7) 84.17% compared to head (bc439da) 84.61%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x      #26      +/-   ##
============================================
+ Coverage     84.17%   84.61%   +0.44%     
- Complexity       53       54       +1     
============================================
  Files             7        7              
  Lines           139      143       +4     
============================================
+ Hits            117      121       +4     
  Misses           22       22              
Impacted Files Coverage Δ
src/Normalizer/RamseyUuidNormalizer.php 80.00% <100.00%> (+7.27%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@msmakouz msmakouz merged commit 21f1888 into 2.x Dec 4, 2023
3 checks passed
@msmakouz msmakouz deleted the bugfix/supported-types branch December 4, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants