-
Notifications
You must be signed in to change notification settings - Fork 0
Clean-up gulp #27
base: master
Are you sure you want to change the base?
Clean-up gulp #27
Conversation
@@ -25,12 +23,4 @@ gulp.task("dist", function() { | |||
.pipe(gulp.dest(opt.outputFolder)); | |||
}); | |||
|
|||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would you like to do so? This is the way to go.
AFAIK I was adding the example here. |
*/ | ||
gulp.task("deploy", ["dist"], function() { | ||
gulp.src("./build/**") | ||
.pipe(deploy("[email protected]:spiral-project/daybed.js.git")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're actually using gh-pages to deploy, I personally feel that's easier to have two branches, one for dev and one for something that's published.
This way, we chose to put what we want on the published pages and we can optimize it for the clients (minify the js for instance).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This gulp task was not very friendly with a non orphan branch.
Look at what I did for gh-pages
in the source tree. That's why I do for many repos, and it works well.
Releasing consists in:
$ git checkout gh-pages
$ git merge vX.Y.Z
$ make dist
$ git commit --amend build/daybed.js
$ git push origin gh-pages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The aim of this task is to automate this and moreover be able to choose the tree for dev and for the gh-pages website.
422971f
to
23e4472
Compare
No description provided.