Currency hotfixes #1240
Currency hotfixes #1240
Conversation
See #1232 for a discussion on currencies
| @@ -615,6 +617,7 @@ def test_bills_with_calculation(self): | |||
| ) | |||
| self.assertStatus(400, req) | |||
|
|
|||
| @pytest.mark.skip(reason="Currency conversion is broken") | |||
There was a problem hiding this comment.
Yay, we benefit from new pytest markers :-)
|
I'd like to release version 6.1.1 as soon as this is merged (which means really soon) |
There was a problem hiding this comment.
Hi, thanks for doing this.
What about adding a test scenario which reproduces the problems we have currently? So we can ensure this is fixed by the changes you're doing here?
If it's too long to do, I think we should merge this and release a bugfix release, but I think it could be a nice addition.
Here is what is disabled: - setting or changing the default currency on an existing project - adding or editing a bill with a currency that differs from the default currency of the project
|
You mean simulating the exception that would be raised by the API call? It's a good idea, that would have allowed us to catch this way earlier. But I'm not motivated enough to do this now... |
I understand, especially as it's a quick fix for an emergency release. Let's move on then, I won't have the time to add it either. Thanks again for doing that! |
|
Thanks for the review! I will make the release now. |
* hotfix: hardcode list of currencies to workaround failing API calls See spiral-project#1232 for a discussion on currencies * Temporarily disable some currency operations to prevent crashes Here is what is disabled: - setting or changing the default currency on an existing project - adding or editing a bill with a currency that differs from the default currency of the project --------- Co-authored-by: Baptiste Jonglez <[email protected]>
Hardcode list of currencies, and temporarily disable some currency operations to prevent crashes.
Here is what is disabled:
Adjust and skip tests as necessary.
The real fix will come after #1232 is discussed