Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite using Class, add registerEasing method #1

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

JordanDelcros
Copy link

Rewrite using the Class way, add « resisterEasing » method.
Update readme and examples.

@noerw
Copy link

noerw commented Apr 22, 2016

looks great, but when trying to migrate from spite's version to yours i'm getting stuck with the error
line 34: TypeError: story[key][step].match(...) is null aka Uncaught TypeError: Cannot read property '0' of null when initializing a new Storyline().

The old storyline data syntax is still supported, right?

Edit: Could it be that negative time indexes are not supported anymore?

@JordanDelcros
Copy link
Author

Can you give me the datas you are using ? :)
I never tried negative times... Is it very usefull ?
There is many differences with the Spite's version.
Your error probably come from the easing names...

Example: "easeinout" become "easeInOut".

Give me more datas, I'll help you. ;)

@noerw
Copy link

noerw commented Apr 27, 2016

I'm currently only using the 'cut to' easing.
Here's my example sequence. I use negative indexes, as those are actually geographic coordinates in my application, and not time.
I could translate them into the positive number range, but with spite's version it worked with negative indexes too.
Would be great to get that running ;)

@JordanDelcros
Copy link
Author

Is it working with this fix ?

@noerw
Copy link

noerw commented Apr 28, 2016

yep, now it works. thanks!
When creating a storyline the data is stored in a variable storyboard, you might want to change that to storyline, as it's a bit confusing..
Could you create the issues section in your fork repo, so such discussion can be continued there?

@JordanDelcros
Copy link
Author

Yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants