test: Set nonzero exitcode when tests fail #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create a single list of quickcheck properties * Test the result of the quickcehck run * Exit with appropriate status code
414owen
force-pushed
the
os/exit-one-on-test-fail
branch
from
c2694e8
to
bc5e551
Compare
spl
reviewed
Feb 17, 2024
spl
reviewed
Feb 17, 2024
spl
reviewed
Feb 17, 2024
|
Hmm, that's interesting. I'm sure I was seeing failures when I worked on tests years ago. 🤦🏼 Ah well, thanks again! 🙏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Branch is based on os/fix-read-after-show-test, so please merge #117 before this.
Previously,
cabal testwould print PASS and exit with exitcode 0, even when a test was failing.