Initial version of the HTTP API + DF upgrade #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we prepare a vector of all futures (PG/HTTP frontends), there's a lifetime issue with the config structs that I don't completely understand (they basically need to live as long as the `'static` lifetime). We can't pass them by reference to the PG/HTTP frontend because that reference might not live as long as static, since we're doing this as a separate function that's called from main (?)). Our `prepare_frontends` function can't own the config either (it has to outlive it). To fix this, we pass the config to the PG/HTTP frontends by-value and clone it.
This is used so that we can mock SeafowlContext easier in unit tests.
(this mocking is getting really painful)
- Parquet hashes changed (probably fine, due to changes in ArrowWriter / DF's
execution output?)
- Output of `SHOW TABLES` changed (new column)
This is to exercise the actual context creation code and remove code duplication
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging this into master because it also contains a DataFusion upgrade and some config parsing and test improvements/fixes; will keep working on HTTP: