Migrate unstable field json repr to a canonical one #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruuya
commented
Aug 7, 2024
| @@ -59,6 +59,39 @@ macro_rules! implement_repository { | |||
| #[async_trait] | |||
| impl Repository for $repo { | |||
| async fn setup(&self) { | |||
| // TODO remove the entire block a couple of releases past 0.5.7 | |||
| { | |||
| // Migrate the old field JSON format to the canonical one | |||
There was a problem hiding this comment.
I've tested the migration locally, it successfully converted
{"children":[],"name":"cc_call_center_sk","nullable":true,"type":{"bitWidth":32,"isSigned":true,"name":"int"}}
{"children":[],"name":"cc_call_center_id","nullable":true,"type":{"name":"utf8"}}
{"children":[],"name":"cc_rec_start_date","nullable":true,"type":{"name":"date","unit":"DAY"}}
...
{"children":[],"name":"RefererHash","nullable":false,"type":{"bitWidth":64,"isSigned":true,"name":"int"}}
{"children":[],"name":"URLHash","nullable":false,"type":{"bitWidth":64,"isSigned":true,"name":"int"}}
{"children":[],"name":"CLID","nullable":false,"type":{"bitWidth":32,"isSigned":true,"name":"int"}}into the following repr
{"name":"cc_call_center_sk","data_type":"Int32","nullable":true,"dict_id":0,"dict_is_ordered":false,"metadata":{}}
{"name":"cc_call_center_id","data_type":"Utf8","nullable":true,"dict_id":0,"dict_is_ordered":false,"metadata":{}}
{"name":"cc_rec_start_date","data_type":"Date32","nullable":true,"dict_id":0,"dict_is_ordered":false,"metadata":{}}
...
{"name":"RefererHash","data_type":"Int64","nullable":false,"dict_id":0,"dict_is_ordered":false,"metadata":{}}
{"name":"URLHash","data_type":"Int64","nullable":false,"dict_id":0,"dict_is_ordered":false,"metadata":{}}
{"name":"CLID","data_type":"Int32","nullable":false,"dict_id":0,"dict_is_ordered":false,"metadata":{}}
mildbyte
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move away from the
arrow_integration_test::{schema_from_json, field_from_json}to the one representation provided via serde directly on the arrow types.We currently don't use the persisted fields anywhere, but add a migration just in case we may need one.