Skip to content

Conversation

@splo
Copy link
Owner

@splo splo commented Dec 20, 2025

Add support to Bevy 0.18.

Copilot AI review requested due to automatic review settings December 20, 2025 18:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for Bevy version 0.18 to the VS Code extension, following the same pattern established for previous versions (0.15, 0.16, 0.17).

Key changes:

  • New TypeScript implementation files for Bevy 0.18 protocol support
  • Updated type unions to include v0.18 services
  • New example server project demonstrating Bevy 0.18 integration
  • Documentation and configuration updates to reference 0.18 as the default/latest version

Reviewed changes

Copilot reviewed 15 out of 17 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/brp/brp-0.18.ts Type definitions for Bevy Remote Protocol 0.18 API
src/brp/http/v0_18JsonRpcBrp.ts JSON-RPC implementation for 0.18 service
src/extension/resources/v0_18ResourceRepository.ts Resource repository implementation for 0.18
src/extension/entities/v0_18EntityTreeRepository.ts Entity tree repository implementation for 0.18
src/extension/components/v0_18ComponentRepository.ts Component repository implementation for 0.18
src/extension/bevyInspectorExtension.ts Added 0.18 case and updated fallback to use 0.18 protocol
src/extension/schemas/remoteSchemaService.ts Extended type union to include V0_18BevyRemoteService
src/extension/entities/entityTreeRepositories.ts Extended type unions to include v0.18 types
examples/server-0.18/src/main.rs Example Bevy 0.18 server application
examples/server-0.18/Cargo.toml Cargo manifest for 0.18 example (has invalid edition)
examples/server-0.18/README.md Documentation for 0.18 example server
README.md Updated Bevy version reference from 0.17 to 0.18
CONTRIBUTING.md Updated example server documentation and port references
.vscode/tasks.json Added task for 0.18 server, adjusted port numbers
.github/ISSUE_TEMPLATE/bug.yml Updated example version from 0.17 to 0.18
package-lock.json Dependency updates (primarily dev dependencies)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

edition = "2024"

[dependencies]
bevy = { version = "=0.18.0-rc.1", features = ["bevy_remote"] }
Copy link

Copilot AI Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Bevy version uses an exact version constraint with a release candidate ("=0.18.0-rc.1"). Since this PR is titled "Support Bevy 0.18", consider whether this should be updated to the stable "0.18.0" release once available, or use a more flexible version constraint like "0.18" to allow patch updates.

Suggested change
bevy = { version = "=0.18.0-rc.1", features = ["bevy_remote"] }
bevy = { version = "0.18", features = ["bevy_remote"] }

Copilot uses AI. Check for mistakes.
[package]
name = "server-018"
version = "0.1.0"
edition = "2024"
Copy link

Copilot AI Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The edition is set to "2024" which is not a valid Rust edition. Valid Rust editions are "2015", "2018", "2021", etc. This should be changed to "2021" or the latest stable edition.

Suggested change
edition = "2024"
edition = "2021"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants