Skip to content

feat: support custom favicons #1864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 23, 2025
Merged

feat: support custom favicons #1864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
639b0a7
support custom favicons
kkedziak-splunk Jul 28, 2025
12bb976
Merge branch 'develop' into feat/favicons
soleksy-splunk Aug 4, 2025
86c6feb
Merge branch 'develop' into feat/favicons
hetangmodi-crest Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion splunk_add_on_ucc_framework/package/appserver/templates/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,19 @@
~ limitations under the License.
~
-->
<%! app_name = cherrypy.request.path_info.split('/')[3] %>\
<%!
from splunk.appserver.mrsparkle.lib import util

app_name = cherrypy.request.path_info.split('/')[3]
%>\
<!DOCTYPE html>
<html class="no-js" lang="">
<head>
<meta charset="utf-8" />
<meta http-equiv="x-ua-compatible" content="ie=edge" />
<title>${_('Loading')}</title>
<meta name="viewport" content="width=device-width, initial-scale=1" />
<link rel="shortcut icon" href="${util.getFaviconURL()}" />
<link rel="apple-touch-icon" href="apple-touch-icon.png" />
<base >
</head>
Expand Down
1 change: 1 addition & 0 deletions tests/smoke/test_ucc_build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ def test_ucc_generate_with_everything(caplog):
("appserver", "static", "test icon.png"),
("appserver", "static", "alerticon.png"),
("appserver", "static", "js", "build", "custom", "custom_tab.js"),
("appserver", "templates", "base.html"),
("default", "alert_actions.conf"),
("default", "eventtypes.conf"),
("default", "inputs.conf"),
Expand Down
12 changes: 9 additions & 3 deletions ...pected_output_global_config_everything/Splunk_TA_UCCExample/appserver/templates/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!--
~ Copyright 2021 Splunk Inc.
~ Copyright 2025 Splunk Inc.
~
~ Licensed under the Apache License, Version 2.0 (the "License");
~ you may not use this file except in compliance with the License.
Expand All @@ -14,15 +14,21 @@
~ limitations under the License.
~
-->
<%! app_name = cherrypy.request.path_info.split('/')[3] %>\
<%!
from splunk.appserver.mrsparkle.lib import util

app_name = cherrypy.request.path_info.split('/')[3]
%>\
<!DOCTYPE html>
<html class="no-js" lang="">
<head>
<meta charset="utf-8" />
<meta http-equiv="x-ua-compatible" content="ie=edge" />
<title>${_('Loading')}</title>
<meta name="viewport" content="width=device-width, initial-scale=1" />
<link rel="shortcut icon" href="${util.getFaviconURL()}" />
<link rel="apple-touch-icon" href="apple-touch-icon.png" />
<base >
</head>

<body>
Expand All @@ -35,6 +41,6 @@

<% page_path = "/static/app/" + app_name + "/js/build/entry_page.js" %>

<script src="${make_url(page_path)}"></script>
<script type="module" src="${make_url(page_path)}"></script>
</body>
</html>
Loading