Skip to content

Conversation

kkedziak-splunk
Copy link
Contributor

@kkedziak-splunk kkedziak-splunk commented Aug 28, 2025

Issue number: ADDON-82672

PR Type

What kind of change does this PR introduce?

  • Feature
  • Bug Fix
  • Refactoring (no functional or API changes)
  • Documentation Update
  • Maintenance (dependency updates, CI, etc.)

Summary

Changes

The UI by default uses a different URL for OAuth2 endpoint that UCC generates. Meaning that we get 404 with a TA generated by UCC, without any manual modifications.

This PR also adds tests for the previously untested functionality.

User experience

No 404's for *_oauth endpoint.

Checklist

If an item doesn't apply to your changes, leave it unchecked.

Review

  • self-review - I have performed a self-review of this change according to the development guidelines
  • Changes are documented. The documentation is understandable, examples work (more info)
  • PR title and description follows the contributing principles
  • meeting - I have scheduled a meeting or recorded a demo to explain these changes (if there is a video, put a link below and in the ticket)

Tests

See the testing doc.

  • Unit - tests have been added/modified to cover the changes
  • Smoke - tests have been added/modified to cover the changes
  • UI - tests have been added/modified to cover the changes
  • coverage - I have checked the code coverage of my changes (see more)

Demo/meeting:

Reviewers are encouraged to request meetings or demos if any part of the change is unclear

# Conflicts:
#	tests/testdata/expected_addons/expected_output_global_config_everything/Splunk_TA_UCCExample/default/restmap.conf
#	tests/testdata/expected_addons/expected_output_global_config_everything/Splunk_TA_UCCExample/default/web.conf
#	tests/testdata/test_addons/package_global_config_everything/package/default/restmap.conf
#	tests/testdata/test_addons/package_global_config_everything/package/default/web.conf
Base automatically changed from fix/oauth_account to develop August 28, 2025 12:20
# Conflicts:
#	tests/testdata/expected_addons/expected_output_global_config_everything/Splunk_TA_UCCExample/bin/splunk_ta_uccexample_rh_organization.py
#	tests/testdata/test_addons/package_global_config_everything/globalConfig.json
#	tests/ui/test_configuration_page_account_tab.py
@kkedziak-splunk kkedziak-splunk changed the title fix(ui): correct OAuth2 url fix(ui): use the correct OAuth2 url Sep 1, 2025
@kkedziak-splunk kkedziak-splunk marked this pull request as ready for review September 1, 2025 06:49
@kkedziak-splunk kkedziak-splunk requested review from a team as code owners September 1, 2025 06:49
@kkedziak-splunk kkedziak-splunk merged commit 0f3effd into develop Sep 16, 2025
114 of 117 checks passed
@kkedziak-splunk kkedziak-splunk deleted the fix/oauth_url branch September 16, 2025 07:33
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants