Skip to content

🔧 chore: add prek static checks#5

Merged
zrr1999 merged 4 commits into
mainfrom
chore/add-prek-tooling
May 4, 2026
Merged

🔧 chore: add prek static checks#5
zrr1999 merged 4 commits into
mainfrom
chore/add-prek-tooling

Conversation

@zrr1999

@zrr1999 zrr1999 commented May 1, 2026

Copy link
Copy Markdown
Member

Summary

  • Add a repo-local prek.toml with shared baseline hooks for file hygiene, strict tombi (--error-on-warnings), actionlint, typos, and published hook manifest validation.
  • Correct the mirror tooling direction from preserving Python 3.8 compatibility to following modern spore-lang requirements: Python 3.13+, modern SPDX license metadata, and setuptools>=77.
  • Make sync automation request Python 3.13 via astral-sh/setup-uv and uv run --python 3.13 --script sync.py.

Validation

  • uv build
  • uvx tombi lint --error-on-warnings pyproject.toml prek.toml
  • uvx prek run --all-files
  • uvx prek validate-manifest .pre-commit-hooks.yaml
  • git diff --check

Notes

  • Kept this PR scoped to spore-pre-commit to avoid overlapping active cross-repo PRs.
  • Did not run uv run --python 3.13 --script sync.py locally because the script can tag, push, and create GitHub releases as part of its normal behavior.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e3d40f1fda

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pyproject.toml
zrr1999 and others added 3 commits May 2, 2026 00:30
Avoid requiring uvx inside the local system hook so j178/prek-action can run the manifest validation in CI.

Co-authored-by: GitHub Copilot <github-copilot[bot]@users.noreply.github.com>
Lower the setuptools build requirement to a Python 3.8-compatible floor and keep license metadata in the PEP 621 table form supported by that backend. Avoid promoting the resulting schema deprecation warning to a failing Tombi hook while Python 3.8 remains supported.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@zrr1999

zrr1999 commented May 4, 2026

Copy link
Copy Markdown
Member Author

Corrected the PR direction per the approved plan:

  • Dropped Python 3.8 compatibility and set both project/script metadata to Python 3.13+.
  • Switched packaging metadata to license = "MIT" with setuptools>=77.
  • Restored strict tombi linting with --error-on-warnings.
  • Updated sync workflow to use Python 3.13 through setup-uv and uv run --python 3.13 --script sync.py.
  • Documented that hook environments follow the mirrored spore-lang Python requirement (currently 3.13+).

Validation passed: uv build, uvx tombi lint --error-on-warnings pyproject.toml prek.toml, uvx prek run --all-files, uvx prek validate-manifest .pre-commit-hooks.yaml, and git diff --check.

Skipped local uv run --python 3.13 --script sync.py because it can tag/push/create releases.

@zrr1999 zrr1999 merged commit d7f4e22 into main May 4, 2026
4 of 5 checks passed
@zrr1999 zrr1999 deleted the chore/add-prek-tooling branch May 4, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant