Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase minimum version to macOS 13.0 #101

Merged
merged 5 commits into from
Sep 20, 2023
Merged

Conversation

Arafo
Copy link
Contributor

@Arafo Arafo commented Aug 30, 2023

Increased minimum macOS version to 13.0 to fix issue #100

@Arafo
Copy link
Contributor Author

Arafo commented Sep 13, 2023

Any idea why is the macOS build failing here @BalestraPatrick?

2023-09-13 08:00:29.278 xctest[15873:39142] The bundle “XCMetricsPackageTests.xctest” couldn’t be loaded. Try reinstalling the bundle.
2023-09-13 08:00:29.278 xctest[15873:39142] (dlopen(/Users/runner/work/XCMetrics/XCMetrics/.build/x86_64-apple-macosx/debug/XCMetricsPackageTests.xctest/Contents/MacOS/XCMetricsPackageTests, 0x0109): Symbol not found: (_$s10Foundation10CocoaErrorV19fileWriteFileExistsAC4CodeVvgZ)
  Referenced from: '/Users/runner/work/XCMetrics/XCMetrics/.build/x86_64-apple-macosx/debug/XCMetricsPackageTests.xctest/Contents/MacOS/XCMetricsPackageTests'
  Expected in: '/System/Library/Frameworks/Foundation.framework/Versions/C/Foundation')
Error: Process completed with exit code 1.

@BalestraPatrick
Copy link
Member

I can't reproduce that failure locally on macOS 13.0. Can you try bumping the version of macOS from macOS-latest to runs-on: macos-13 explicitly?

@Arafo
Copy link
Contributor Author

Arafo commented Sep 19, 2023

Done!

@BalestraPatrick BalestraPatrick merged commit d8212ff into spotify:main Sep 20, 2023
2 checks passed
@samuelsainz
Copy link

hey @BalestraPatrick, any chance you guys can release this fix? I'm still getting this error with v0.0.13. Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants