Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change metric in create_split #301

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

goodloop
Copy link

@goodloop goodloop commented May 29, 2018

correct me if I'm wrong.

I think the create_split() method is used to find two mean points p,q. and we will split the nodes later with method to compare the distance difference between p,node[i] and q,node[i] for each node in current hyperplane.

and we will use dot(n, node[i]) for quick calculation.
because n=p-q, so
dot(n, node[i]) = dot(p, node[i]) - dot(q, node[i])

if we can keep p and q are normalized. dot(n, node[i]) may be better for representing the node i is near p or q in Angular metric.

@erikbern
Copy link
Collaborator

interesting – let me take a look later this week

@goodloop
Copy link
Author

@erikbern any thoughts about this?

@erikbern
Copy link
Collaborator

erikbern commented Oct 8, 2018

Hey I completely forgot about this one. Just rebased it. Let me see if it works and if it impacts performance.

@goodloop
Copy link
Author

goodloop commented Oct 8, 2018

sounds great! Pls remind me if any result you get.

@goodloop
Copy link
Author

goodloop commented Jan 7, 2019

@erikbern any problem about this pr?

@erikbern
Copy link
Collaborator

erikbern commented Jan 7, 2019

sorry forgot about this one, will take a look

Copy link

@Prettytasha Prettytasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Good"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants