change metric in create_split #301
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
interesting – let me take a look later this week |
|
@erikbern any thoughts about this? |
|
Hey I completely forgot about this one. Just rebased it. Let me see if it works and if it impacts performance. |
|
sounds great! Pls remind me if any result you get. |
|
@erikbern any problem about this pr? |
|
sorry forgot about this one, will take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
correct me if I'm wrong.
I think the
create_split()method is used to find two mean points p,q. and we will split the nodes later with method to compare the distance difference between p,node[i] and q,node[i] for each node in current hyperplane.and we will use dot(n, node[i]) for quick calculation.
because
n=p-q, sodot(n, node[i]) = dot(p, node[i]) - dot(q, node[i])if we can keep p and q are normalized. dot(n, node[i]) may be better for representing the node i is near p or q in Angular metric.