fix(go): Better error messaging for sticky rules #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziodemaria
force-pushed
the
sticky-error-msg
branch
from
ceed525 to
aa3ad3f
Compare
nicklasl
reviewed
Nov 6, 2025
nicklasl
reviewed
Nov 6, 2025
openfeature-provider/go/confidence/swap_wasm_resolver_api_test.go
Outdated
Show resolved
Hide resolved
nicklasl
reviewed
Nov 6, 2025
openfeature-provider/go/confidence/swap_wasm_resolver_api_test.go
Outdated
Show resolved
Hide resolved
nicklasl
reviewed
Nov 6, 2025
openfeature-provider/go/confidence/swap_wasm_resolver_api_test.go
Outdated
Show resolved
Hide resolved
nicklasl
reviewed
Nov 6, 2025
openfeature-provider/go/confidence/swap_wasm_resolver_api_test.go
Outdated
Show resolved
Hide resolved
nicklasl
reviewed
Nov 6, 2025
openfeature-provider/go/confidence/swap_wasm_resolver_api_test.go
Outdated
Show resolved
Hide resolved
nicklasl
reviewed
Nov 6, 2025
openfeature-provider/go/confidence/swap_wasm_resolver_api_test.go
Outdated
Show resolved
Hide resolved
nicklasl
reviewed
Nov 6, 2025
openfeature-provider/go/confidence/swap_wasm_resolver_api_test.go
Outdated
Show resolved
Hide resolved
nicklasl
reviewed
Nov 6, 2025
openfeature-provider/go/confidence/local_resolver_provider_resolve_test.go
Show resolved
Hide resolved
- Remove duplicate tests between local_resolver_provider_resolve_test.go and swap_wasm_resolver_api_test.go - Remove non-sticky-related tests (TypeMismatch, InvalidClientSecret, NestedValues) as they're not relevant to the PR's focus on sticky rules error messaging - Fix naming consistency: rename TestResolverApi_* to TestSwapWasmResolverApi_* for consistency - Improve test names: "MinimalState" → "NonExistentFlag", "Basic" → "DirectInstanceCall" - Simplify TestLocalResolverProvider_MissingMaterializations to focus on provider-level behavior The main test coverage for missing materializations is now in TestSwapWasmResolverApi_ResolveWithSticky_MissingMaterializations which validates the actual response structure. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
fabriziodemaria
force-pushed
the
sticky-error-msg
branch
from
0cc3249 to
6015165
Compare
fabriziodemaria
force-pushed
the
sticky-error-msg
branch
from
650cd18 to
e0248e3
Compare
nicklasl
reviewed
Nov 7, 2025
openfeature-provider/go/confidence/swap_wasm_resolver_api_test.go
Outdated
Show resolved
Hide resolved
nicklasl
reviewed
Nov 7, 2025
openfeature-provider/go/confidence/swap_wasm_resolver_api_test.go
Outdated
Show resolved
Hide resolved
nicklasl
reviewed
Nov 7, 2025
openfeature-provider/go/confidence/swap_wasm_resolver_api_test.go
Outdated
Show resolved
Hide resolved
nicklasl
reviewed
Nov 7, 2025
openfeature-provider/go/confidence/swap_wasm_resolver_api_test.go
Outdated
Show resolved
Hide resolved
nicklasl
reviewed
Nov 7, 2025
openfeature-provider/go/confidence/swap_wasm_resolver_api_test.go
Outdated
Show resolved
Hide resolved
nicklasl
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means moving away from
ResolvetowardsResolveWithStickyBehaviour
Sticky rules will cause an erroneous evaluation with error message "missing materialization". Before the flag would just be marked as "Not found".
Note that no Materialization solution is added yet, so sticky rules are still not supported: only the error message is improved at this stage
Tests
local_resolver_provider_resolve_test.go.