chore: do not expose the artefact for open feature sdk #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vahidlazio
requested review from
fabriziodemaria,
nicklasl and
nickybondarenko
as code owners
vahidlazio
force-pushed
the
use-maven-open-feature
branch
from
0f0543a
to
b48f10d
Compare
Signed-off-by: vahid torkaman <[email protected]>
vahidlazio
force-pushed
the
use-maven-open-feature
branch
from
b48f10d
to
01655e5
Compare
vahidlazio
changed the title
|
What do we/or the consumers of this SDK gain from this change? |
|
@nicklasl ideally the consumers have one kotlin sdk and they can switch to different providers or have multiple providers, if the providers expose their own sdk this will be problematic in the future. |
OK, I can get on board that. But we would need to update the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.