fix: return correct types instead of casting with as #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: This changes the return type of all endpoints during development, as they can now return undefined in Typescript land
Summary
The makeRequest function in the SpotifyApi class has a return type of
Promise<TReturnType>
, but it can and will returnPromise<null>
in some casesChanges
This can cause exceptions when using the SDK. So this PR fixes this to use the actual type
Promise<TReturnType|null>
, so these errors can be caught during the type check in development.Results
No actual changes in behaviour, just in the Typescript types