Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phpstan issues, upgrade to latest phpstan release #235

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Fix phpstan issues, upgrade to latest phpstan release #235

merged 1 commit into from
Oct 12, 2023

Conversation

thePanz
Copy link
Contributor

@thePanz thePanz commented Oct 5, 2023

No description provided.

@sprain
Copy link
Owner

sprain commented Oct 5, 2023

Could you provide some context here?

@thePanz
Copy link
Contributor Author

thePanz commented Oct 5, 2023

I temporarily upgraded the phpstan level to 7, and new errors appeared.
Those fixes are for that "next" level, while I do not have time to fully fix all level=7 issues at the moment :)

@@ -2,6 +2,4 @@ parameters:
level: 6
paths:
- src/
ignoreErrors:
- '#Parameter \#1 \$h of method TCPDF::setCellHeightRatio\(\) expects int, float given\.#'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error is fixed already, not reported anymore

@sprain sprain merged commit 3a79742 into sprain:master Oct 12, 2023
7 checks passed
@thePanz thePanz deleted the updarte-phpstan-level-6 branch October 12, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants