Allow to use non-compact QR codes with TcPdfOutput #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sprain
changed the title
…de-options # Conflicts: # .gitignore # composer.lock
This was referenced May 15, 2024
Closed
|
@kohlerdominik @sdespont |
|
Ok for me. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #250.
Fixes #249
This makes sure the file size of invoices created with
TcPdfOutputis not unnecessarily inflated.With
endroid/qr-code5.0.8, the default behaviour was changed to create optimized SVGs with the<path>element. However, for some unknown reason this inflates the filze size of invoices created withTcPdfOutput, even though the file size of the qr code becomes smaller.In
endroid/qr-code5.0.9, an option was added to create SVGs in the "old style" again, using<defs>elements. This is what we want to use forTcPdfOutput, if available.This PR takes care of that. It also covers test cases for SVG qr codes created in both styles.