Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding translation to taxonomy fix #262

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

kpokorski
Copy link
Contributor

Fix to situation, where it was not possible to add a translation of taxonomy, when the language of a store was not English.
The solution includes changing the way the translation is saved.

Copy link
Member

@kshalot kshalot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be covered with unit tests as well. That looks like a bug that could be avoided by using a proper test suite.

app/controllers/concerns/spree/admin/translatable.rb Outdated Show resolved Hide resolved
@rafalcymerys rafalcymerys merged commit 2db2ba0 into main Sep 4, 2023
9 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/adding-translation-to-taxonomy branch September 4, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants