GH-1097 Ensure empty POJO converted to {} instead of null

Resolves #1097
spring-cloud · Mar 27, 2024 · 8745f32 · 8745f32
1 parent cea464a
commit 8745f32
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/...pringframework/cloud/function/context/config/ContextFunctionCatalogAutoConfiguration.java b/...pringframework/cloud/function/context/config/ContextFunctionCatalogAutoConfiguration.java
@@ -219,8 +219,8 @@ private JsonMapper jackson(ApplicationContext context) {
 			}
 			catch (Exception e) {
 				mapper = new ObjectMapper();
-				mapper.configure(SerializationFeature.FAIL_ON_EMPTY_BEANS, false);
 			}
+			mapper.configure(SerializationFeature.FAIL_ON_EMPTY_BEANS, false);
 			return new JacksonMapper(mapper);
 		}
 	}

diff --git a/...springframework/cloud/function/context/catalog/BeanFactoryAwareFunctionRegistryTests.java b/...springframework/cloud/function/context/catalog/BeanFactoryAwareFunctionRegistryTests.java
@@ -106,6 +106,15 @@ public void before() {
 		System.clearProperty("spring.cloud.function.definition");
 	}
 
+	@SuppressWarnings({ "rawtypes", "unchecked" })
+	@Test
+	public void testEmptyPojoConversion() {
+		FunctionCatalog catalog = this.configureCatalog(EmptyPojoConfiguratioin.class);
+		Function function = catalog.lookup("echo");
+		String result = (String) function.apply(MessageBuilder.withPayload(new EmptyPojo()).build());
+		assertThat(result).isEqualTo("{}");
+	}
+
 	@Test
 	public void testFunctionEligibilityFiltering() {
 		System.setProperty("spring.cloud.function.ineligible-definitions", "asJsonNode");
@@ -1433,4 +1442,17 @@ public void setData(V data) {
 			this.data = data;
 		}
 	}
+	@EnableAutoConfiguration
+	@Configuration
+	public static class EmptyPojoConfiguratioin {
+
+		@Bean
+		public Function<String, String> echo() {
+			return v -> v;
+		}
+	}
+
+	public static class EmptyPojo {
+
+	}
 }