add gray routing predicate support. #3101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caichengw
changed the title
spencergibb
requested changes
Nov 3, 2023
.../java/org/springframework/cloud/gateway/handler/predicate/OpenGrayRoutePredicateFactory.java
Outdated
Show resolved
Hide resolved
kimmking
suggested changes
Jan 14, 2024
.../java/org/springframework/cloud/gateway/handler/predicate/OpenGrayRoutePredicateFactory.java
Outdated
Show resolved
Hide resolved
| import org.springframework.validation.annotation.Validated; | ||
| import org.springframework.web.server.ServerWebExchange; | ||
|
|
||
| /** |
There was a problem hiding this comment.
Add some details for describing this gray filter?
…rayRoutePredicateFactory when hash value equals int.min_value.
…rayRoutePredicateFactory when hash value equals int.min_value.
|
Why not use a percent value for gray, but use a specific range value now? |
|
spencergibb
requested changes
Mar 8, 2024
| } | ||
|
|
||
|
|
||
| int hash = Math.abs(MurmurHash3.hash32x86(patternValue.getBytes(StandardCharsets.UTF_8))% MAX_WEIGHT_RANGE) ; |
There was a problem hiding this comment.
Let's create an interface that extends Function<byte[], int> and require a bean of that type for this to work. That way the use of apache commons doesn't leak here.
| import java.util.Objects; | ||
| import java.util.Optional; | ||
| import java.util.function.Predicate; | ||
| import org.apache.commons.codec.digest.MurmurHash3; |
There was a problem hiding this comment.
remove hard dependency on apache commons
| <groupId>commons-codec</groupId> | ||
| <artifactId>commons-codec</artifactId> | ||
| <version>1.16.0</version> | ||
| <scope>compile</scope> |
spencergibb
added
feedback-provided
waiting for feedback
and removed
waiting for feedback
feedback-provided
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add gray routing predicate support based on request params(path,query,cookie or header), use consistent hashing other than random selection.