-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework LocalResponseCache into a general ResponseCache to support Caffiene and Redis CacheManagers #3145
base: main
Are you sure you want to change the base?
Rework LocalResponseCache into a general ResponseCache to support Caffiene and Redis CacheManagers #3145
Conversation
…ayFilter. Split out LocalResponseCacheAutoConfiguration and RedisResponseCacheAutoConfiguration
Anything we do at this point needs to be backwards compatible. We don't do breaking changes, for the most part, unless it's a major release and we will not be doing one for a while. |
@spencergibb that makes sense. I'm willing to work on shuffling this around into a non-breaking PR. Breaking changes aside - Do you have any feedback on the idea behind the PR? Is there appetite for inclusion of a pluggable cache implementation for response caching? |
I think it makes sense, but it would need to be reworked. No rush. |
Any chance you can rebase? No rush, this would be part of our 2024.0 release train. |
LocalResponseCacheGatewayFilterFactory offers a lot of great functionality assuming that you're fine with a Caffiene-backed cache implementation. For my particular use case, I'm interested in using a Redis cache and distributing the cache storage across several instances of the spring-cloud-gateway app.
This pull request:
LocalResponseCache*
toResponseCache*
Any feedback/suggestions are appreciated. If modifications are required in order to get this back into the mainline please let me know.