Add request temp file buffer (#3479)#3659
Add request temp file buffer (#3479)#3659Milkdove wants to merge 6 commits intospring-cloud:mainfrom
Conversation
|
Shouldn't the gateway stream the file? Or are you using filters that may be reading the body? |
|
Strictly speaking, the current MVC version of the Gateway doesn't truly support streaming transmission. Its process involves reading the request, caching it, and then sending it out. This approach can lead to Out Of Memory (OOM) issues, as seen in some cases. |
|
This version was built specifically for Spring WebMVC and blocking IO is part of that. When Zuul was supported, there was an option to install it as a servlet outside the spring dispatcher servlet, and that's how large uploads were handled. We don't really have either of those options. This seems like a good middle ground. |
| @@ -75,4 +75,9 @@ private int copyResponseBodyWithFlushing(InputStream inputStream, OutputStream o | |||
| return totalReadBytes; | |||
| } | |||
|
|
|||
|
|
|||
| protected boolean isWriteClientBodyToFile(Request request) { | |||
| return properties.isFileBufferEnabled() && request.getServerRequest().servletRequest().getContentLength() >= properties.getFileBufferSizeThreshold().toBytes(); | |||
There was a problem hiding this comment.
I wonder if this should include a content type check as well?
There was a problem hiding this comment.
This is mainly about OOM protection.
Whether we write to disk isn’t really tied to content-type, but to request size and memory safety.
We could add content-type based config later if there’s a real need, but I’d prefer to keep this logic simple for now.
Milkdove
force-pushed
the
add_proxy_temp_file
branch
2 times, most recently
from
b4a7fd0 to
cb85a78
Compare
Signed-off-by: Milkdove <pollux.li@outlook.com>
… logic (spring-cloud#3479) Signed-off-by: Milkdove <pollux.li@outlook.com>
Signed-off-by: Milkdove <pollux.li@outlook.com>
… logic (spring-cloud#3479) Signed-off-by: Milkdove <pollux.li@outlook.com>
Milkdove
force-pushed
the
add_proxy_temp_file
branch
from
cb85a78 to
207e667
Compare
Signed-off-by: Milkdove <49242304+Milkdove@users.noreply.github.com>
Signed-off-by: Milkdove <pollux.li@outlook.com>
4 participants
Add the feature of using temp file as intermediaries when forwarding large requests, which can effectively solve the OOM, and added two configs to control it:
I'm not sure if this solution is appropriate. It may cause some large requests to be slowed down.But I don’t have any other ideas at the moment. This is the solution our team uses. In addition, should the default value of file-buffer-enabled be true?