-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Spring Boot 3.4.1 #600
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the CI/CD build it looks like something has to be installed first:
Error: Failed to execute goal on project zeromq-sink-kafka: Could not resolve dependencies for project org.springframework.cloud.stream.app:zeromq-sink-kafka:jar:6.0.0-SNAPSHOT: The following artifacts could not be resolved: org.springframework.cloud.stream.app:stream-applications-composite-function-support:jar:6.0.0-SNAPSHOT, org.springframework.cloud.stream.app:stream-applications-micrometer-common:jar:6.0.0-SNAPSHOT, org.springframework.cloud.stream.app:stream-applications-security-common:jar:6.0.0-SNAPSHOT, org.springframework.cloud.stream.app:stream-applications-postprocessor-common:jar:6.0.0-SNAPSHOT: org.springframework.cloud.stream.app:stream-applications-composite-function-support:jar:6.0.0-SNAPSHOT was not found in https://repo.spring.io/snapshot during a previous attempt. This failure was cached in the local repository and resolution is not reattempted until the update interval of spring-snapshots has elapsed or updates are forced
c4cbec2
to
763844a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Chris, for doing this!
In general, this is OK, but I wonder if my comments make sense, at least for the future consideration.
...est/java/org/springframework/cloud/stream/app/sink/elasticsearch/ElasticsearchSinkTests.java
Show resolved
Hide resolved
I cleaned up more unnecessary dependency management and I think this one is ready besides that fact that the CI is still failing due to the unmerged spring-cloud-function fix. Once that is merged this should go 💚 |
stream-applications-build/pom.xml
Outdated
<version>${okhttp3.version}</version> | ||
<type>pom</type> | ||
<scope>import</scope> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, Chris!
But what is going on with indents?
Not all of them are tabs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It only seems to be in xml files. I wiill check my format settings.
@@ -17,7 +17,7 @@ | |||
|
|||
<properties> | |||
<stream-apps-core.version>6.0.0-SNAPSHOT</stream-apps-core.version> | |||
<java-functions.version>5.0.1</java-functions.version> | |||
<java-functions.version>5.1.0-SNAPSHOT</java-functions.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this PR is also fixing #603.
Would you mind to mention that as a Fixes: #603
sentence in the commit message?
Spring Cloud Function fix has been merged, but PR build still fails and no clue from those logs why 😢 |
I will dig into a figure out what is going on. |
This commit updates the following dependencies: - Spring Boot to 3.4.2-SNAPSHOT - Spring Cloud 2024.0.1-SNAPSHOT - Spring Functions Catalog 5.1.0-SNAPSHOT Also removes these unnecessary version properties: - spring-cloud-stream.version - spring-cloud-function.version - spring-cloud-starters.version Also removes dependency mgmt for the following: - testcontainers-bom - junit-bom - jakarta-jms-api - groovy-bom Resolves spring-cloud#599 spring-cloud#600
424bf8e
to
b67c924
Compare
This commit removes the DebeziumSupplierAvroFormatTest as it relies on a dependency that has been removed in Spring Integration and stream-applications. We should not need to test Debezium support for Avro encoding.
This commit updates the following dependencies:
Resolves #599