Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Spring Boot 3.4.1 #600

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

onobc
Copy link
Collaborator

@onobc onobc commented Dec 19, 2024

This commit updates the following dependencies:

  • Spring Boot to 3.4.1
  • Spring Framework to 6.2.1
  • Spring Cloud 2024.0.0
  • Spring Cloud Function 4.2.0
  • Spring Cloud Stream 4.2.0

Resolves #599

@onobc onobc requested a review from artembilan December 19, 2024 20:55
stream-applications-build/pom.xml Outdated Show resolved Hide resolved
Copy link
Collaborator

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the CI/CD build it looks like something has to be installed first:

Error:  Failed to execute goal on project zeromq-sink-kafka: Could not resolve dependencies for project org.springframework.cloud.stream.app:zeromq-sink-kafka:jar:6.0.0-SNAPSHOT: The following artifacts could not be resolved: org.springframework.cloud.stream.app:stream-applications-composite-function-support:jar:6.0.0-SNAPSHOT, org.springframework.cloud.stream.app:stream-applications-micrometer-common:jar:6.0.0-SNAPSHOT, org.springframework.cloud.stream.app:stream-applications-security-common:jar:6.0.0-SNAPSHOT, org.springframework.cloud.stream.app:stream-applications-postprocessor-common:jar:6.0.0-SNAPSHOT: org.springframework.cloud.stream.app:stream-applications-composite-function-support:jar:6.0.0-SNAPSHOT was not found in https://repo.spring.io/snapshot during a previous attempt. This failure was cached in the local repository and resolution is not reattempted until the update interval of spring-snapshots has elapsed or updates are forced

@onobc onobc force-pushed the GH-599-update-boot-3_4_1 branch 3 times, most recently from c4cbec2 to 763844a Compare December 22, 2024 19:16
Copy link
Collaborator

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Chris, for doing this!
In general, this is OK, but I wonder if my comments make sense, at least for the future consideration.

stream-applications-build/pom.xml Outdated Show resolved Hide resolved
stream-applications-build/pom.xml Show resolved Hide resolved
stream-applications-build/pom.xml Outdated Show resolved Hide resolved
stream-applications-build/pom.xml Outdated Show resolved Hide resolved
@onobc onobc requested a review from artembilan January 6, 2025 19:11
@onobc
Copy link
Collaborator Author

onobc commented Jan 6, 2025

I cleaned up more unnecessary dependency management and I think this one is ready besides that fact that the CI is still failing due to the unmerged spring-cloud-function fix. Once that is merged this should go 💚

<version>${okhttp3.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, Chris!
But what is going on with indents?
Not all of them are tabs?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It only seems to be in xml files. I wiill check my format settings.

@@ -17,7 +17,7 @@

<properties>
<stream-apps-core.version>6.0.0-SNAPSHOT</stream-apps-core.version>
<java-functions.version>5.0.1</java-functions.version>
<java-functions.version>5.1.0-SNAPSHOT</java-functions.version>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this PR is also fixing #603.
Would you mind to mention that as a Fixes: #603 sentence in the commit message?

@artembilan
Copy link
Collaborator

Spring Cloud Function fix has been merged, but PR build still fails and no clue from those logs why 😢

@onobc
Copy link
Collaborator Author

onobc commented Jan 8, 2025

Spring Cloud Function fix has been merged, but PR build still fails and no clue from those logs why 😢

I will dig into a figure out what is going on.

This commit updates the following dependencies:

- Spring Boot to 3.4.2-SNAPSHOT
- Spring Cloud 2024.0.1-SNAPSHOT
- Spring Functions Catalog 5.1.0-SNAPSHOT

Also removes these unnecessary version properties:
- spring-cloud-stream.version
- spring-cloud-function.version
- spring-cloud-starters.version

Also removes dependency mgmt for the following:
- testcontainers-bom
- junit-bom
- jakarta-jms-api
- groovy-bom

Resolves spring-cloud#599 spring-cloud#600
@onobc onobc force-pushed the GH-599-update-boot-3_4_1 branch from 424bf8e to b67c924 Compare January 8, 2025 20:35
This commit removes the DebeziumSupplierAvroFormatTest as it
relies on a dependency that has been removed in Spring Integration
and stream-applications. We should not need to test Debezium
support for Avro encoding.
@artembilan artembilan merged commit 95550f0 into spring-cloud:main Jan 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Spring Boot to 3.4.x (main)
2 participants