Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add active health check feature #288

Closed
wants to merge 3 commits into from
Closed

Add active health check feature #288

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
618a396
Add active health check feature
MarianConstantinMarica Nov 17, 2024
6b903b6
Delete redundant property
MarianConstantinMarica Nov 17, 2024
e2c48a1
Move the active health check properties to config repository
MarianConstantinMarica Nov 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions spring-petclinic-api-gateway/src/main/resources/application.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ spring:
config:
import: optional:configserver:${CONFIG_SERVER_URL:http://localhost:8888/}
cloud:
loadbalancer:
configurations: health-check
Copy link
Member

@arey arey Nov 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: did you test this health-check configuration? and how? Did you have some logs?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarianConstantinMarica Did you have any logs?

gateway:
routes:
- id: vets-service
Expand Down
7 changes: 7 additions & 0 deletions spring-petclinic-customers-service/src/main/resources/application.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@ spring:
import: optional:configserver:${CONFIG_SERVER_URL:http://localhost:8888/}


management:
endpoints:
web:
exposure:
include: health


---
spring:
config:
Expand Down
7 changes: 7 additions & 0 deletions spring-petclinic-vets-service/src/main/resources/application.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,13 @@ spring:
profiles:
active: production

management:
arey marked this conversation as resolved.
Show resolved Hide resolved
endpoints:
web:
exposure:
include: health


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: this pull request seems to be empty. Isn't it?

---
spring:
config:
Expand Down
6 changes: 6 additions & 0 deletions spring-petclinic-visits-service/src/main/resources/application.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ spring:
config:
import: optional:configserver:${CONFIG_SERVER_URL:http://localhost:8888/}

management:
endpoints:
web:
exposure:
include: health


---
spring:
Expand Down
Loading