Move named channel back into autoconfigure module #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves the channel config ("NamedChannel") back to
autoconfigure module as the effort to move to core turns out to
be more trouble than it is worth at this time.
Fixes spring-projects-experimental#92
onobc
commented
Jan 13, 2025
| } | ||
|
|
||
| @Override | ||
| public String getTarget(String authority) { |
There was a problem hiding this comment.
I found that having the getTarget next to the getChannel made the code a bit easier to follow than when it was in the NamedChannelVirtualTargets.
onobc
commented
Jan 13, 2025
| /** | ||
| * Represents the configuration for a {@link ManagedChannel gRPC channel}. | ||
| */ | ||
| public static class ChannelConfig { |
There was a problem hiding this comment.
This is identically the NamedChannel from core renamed to ChannelConfig. Removing the "named" from the name removes the implication that it is has a name but rather it is just channel configuration.
I am ok w/ NamedChannel as well though and really I know better than renaming during a move around like this. I am glad to move it back - just lmk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves the channel config ("NamedChannel") back to autoconfigure module as the effort to move to core turns out to be more trouble than it is worth at this time.
Fixes #92