Support userText rendering strategy in RetrievalAugmentationAdvisor #2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The input userText to the advisor might contain the templating special characters for other purposes than templating (e.g. when including source code). A new UserTextProcessor functional interface allows to customize how the userText is processed when taking as input to the RetrievalAugmentationAdvisor. By default, the PromptTemplateUserTextProcessor implementation is used. If you want to disable the rendering step altogether, you can use the NoOpUserTextProcessor implementation. Signed-off-by: Thomas Vitale <[email protected]>
|
@marcushellberg what do you think? |
|
Even if rendering is not happening due to How should this issue be resolved? AdvisedRequest.java #toPrompt()
if (StringUtils.hasText(processedUserText)) {
Map<String, Object> userParams = new HashMap<>(this.userParams());
if (StringUtils.hasText(formatParam)) {
userParams.put("spring_ai_soc_format", formatParam);
}
if (!CollectionUtils.isEmpty(userParams)) {
processedUserText = new PromptTemplate(processedUserText, userParams).render();
}
messages.add(new UserMessage(processedUserText, this.media()));
} |
|
That scenario will be handled by the new prompt templating solution that is coming up soon to allow greater flexibility and customisation options. In this PR, we only address the specific use case of the prompt templating action in the RAG advisor. |
|
ok to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input
userTextto the advisor might contain the templating special characters for other purposes than templating (e.g. when including source code). A newUserTextProcessorfunctional interface allows to customize how theuserTextis processed when taken as input to theRetrievalAugmentationAdvisor. By default, thePromptTemplateUserTextProcessorimplementation is used. If you want to disable the rendering step altogether, you can use theNoOpUserTextProcessorimplementation.