Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add missing placeholder for TABLE_NAME in MariaDB table existence check #2513

Closed
wants to merge 1 commit into from

Conversation

91wangmeng
Copy link
Contributor

Fix table existence check in MariaDBSchemaValidator

Issue:
The SQL query in the isTableExists method of MariaDBSchemaValidator class has a syntax error. The original query is missing a placeholder for TABLE_NAME, which results in an incomplete SQL statement and affects the table existence check functionality.

Changes:

  • Added %s placeholder for TABLE_NAME in the SQL query
  • Ensured String.format method correctly uses both schemaName and tableName parameters

This fix ensures the table existence check functionality works properly in the MariaDB vector store implementation.

@dev-jonghoonpark
Copy link
Contributor

Nice job! 🙌 Please fix the DCO check by signing your commit. git commit --amend --signoff

@ilayaperumalg
Copy link
Member

@91wangmeng Thanks for fixing the missing placeholder value. Fixed the format issue, rebased and merged as 2294c5a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants