Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tools.adoc Article 2 of the Overview. response —> request #2574

Closed
wants to merge 1 commit into from

Conversation

RobinElysia
Copy link

This should be a request, the model makes a request to the tool

Thank you for taking time to contribute this pull request!
You might have already read the [contributor guide][1], but as a reminder, please make sure to:

  • Sign the contributor license agreement
  • Rebase your changes on the latest main branch and squash your commits
  • Add/Update unit tests as needed
  • Run a build and make sure all tests pass prior to submission

This should be a request, the model makes a request to the tool

Signed-off-by: qwp_p <[email protected]>
@@ -126,7 +126,7 @@ Spring AI supports tool calling through a set of flexible abstractions that allo
image::tools/tool-calling-01.jpg[The main sequence of actions for tool calling, width=700, align="center"]

1. When we want to make a tool available to the model, we include its definition in the chat request. Each tool definition comprises of a name, a description, and the schema of the input parameters.
2. When the model decides to call a tool, it sends a response with the tool name and the input parameters modeled after the defined schema.
2. When the model decides to call a tool, it sends a request with the tool name and the input parameters modeled after the defined schema.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RobinElysia, The response is the correct one as the application needs to process Model's chat response which would contain the tool name etc.,. as part of the response for the initial chat request. Please check the flow diagram which will make it clear. If there is anything we can make it to describe better, let us know. Thanks!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think I get it

@ilayaperumalg ilayaperumalg self-assigned this Mar 26, 2025
@ilayaperumalg ilayaperumalg added the invalid This doesn't seem right label Mar 26, 2025
@ilayaperumalg
Copy link
Member

@RobinElysia Thanks for your contribution. As this change is incorrect, I am closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants