[GH-2609] Fix resource leak issue in VertexAiTextEmbeddingModel #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigomalara
changed the title
rodrigomalara
commented
Mar 31, 2025
| @@ -128,37 +128,38 @@ public EmbeddingResponse call(EmbeddingRequest request) { | |||
| .observation(this.observationConvention, DEFAULT_OBSERVATION_CONVENTION, () -> observationContext, | |||
| this.observationRegistry) | |||
| .observe(() -> { | |||
| PredictionServiceClient client = createPredictionServiceClient(); | |||
| try (PredictionServiceClient client = createPredictionServiceClient()) { | |||
|
Looks good! 👍 |
eternachen
approved these changes
Apr 1, 2025
…eddingModel The PredictionServiceClient was not being closed. Connections are kept open preventing resources from being disposed properly. Signed-off-by: rmalara <[email protected]> [spring-projectsGH-2609] Fix the thread leak issue in VertexAiTextEmbeddingModel The PredictionServiceClient was not being closed. Connections are kept open preventing resources from being disposed properly. Signed-off-by: Rodrigo Malara <[email protected]> Signed-off-by: rmalara <[email protected]> [spring-projectsGH-2609] Fix the thread leak issue in VertexAiTextEmbeddingModel The PredictionServiceClient was not being closed. Connections are kept open preventing resources from being disposed properly. Signed-off-by: Rodrigo Malara <[email protected]> Signed-off-by: rmalara <[email protected]>
Good deal! Rebase should be in place now. |
|
Closed via 2517ca8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PredictionServiceClient was not being closed.
Connections are kept open preventing resources from being disposed properly.
Fixes #2609
Thank you for taking time to contribute this pull request!
You might have already read the [contributor guide][1], but as a reminder, please make sure to:
mainbranch and squash your commits