Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CassandraChatMemory #858

Conversation

michaelsembwever
Copy link
Contributor

@michaelsembwever michaelsembwever commented Jun 12, 2024

@tzolov
Copy link
Contributor

tzolov commented Jun 13, 2024

This is really cool! Thanks @michaelsembwever

Let me know if stumble on some design flows with simplistic ChatMemory interface.

@michaelsembwever michaelsembwever force-pushed the mck/CassandraChatMemory branch 2 times, most recently from af24a6b to 3da8f97 Compare June 14, 2024 21:15
@michaelsembwever michaelsembwever force-pushed the mck/CassandraChatMemory branch 2 times, most recently from d31d970 to 2179f13 Compare July 7, 2024 19:17
Provides a flexible schema, can be combined with a vector store, and supports time-to-live rows.

And, fix initialize-schema docs and so that it actually works.
@michaelsembwever michaelsembwever marked this pull request as ready for review July 7, 2024 21:20
@michaelsembwever
Copy link
Contributor Author

@tzolov ready for review.

Second commit is refactoring of CommonVectorStoreProperties to what i believe is a better package location.

@tzolov tzolov self-assigned this Jul 17, 2024
@tzolov tzolov added this to the 1.0.0-M2 milestone Jul 17, 2024
@tzolov
Copy link
Contributor

tzolov commented Jul 17, 2024

Thanks @michaelsembwever
LGTM. you've forgotten to add the CassandraAutoConfiguration to the AutoConfiguration.imports. But I will fix it during the merge.

FYI, after M2, we will explore how to implement a "generic" Spring Data Chat Memory support that might affect your impl. as well.
Anyway, this is the first persistent chat memory implementation! :)

@tzolov
Copy link
Contributor

tzolov commented Jul 17, 2024

Rebased, squashed and merged at 4aacab0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants