Bug fix: fix failed prompt template validation if a variable name contains hyphen(-) #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the update! merged in 5417d19 |
szarpul
added a commit
to szarpul/spring-ai
that referenced
this pull request
Jul 9, 2024
* After the fix done in spring-projects#944, the tests were still not passing. * Following the fix for spring-projects#944, we should compare text blocks against normalized EOL. * If our goal is to have normalized EOL, then there is no sens to hardcode a `\n` as the target value in `BeanOutputConverterTest.normalizesLineEndingsClassType` test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix for #943 .
After some troubleshooting, I find that the bug was introduced by old-versioned StringTemplate4.
There is an issue about this: antlr/stringtemplate4#94
I upgrade StringTemplate4 to the latest version and add a UT to cover this.
Thank you for taking time to contribute this pull request!
You might have already read the [contributor guide][1], but as a reminder, please make sure to:
mainbranch and squash your commits