Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows line separation. #949

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix Windows line separation. #949

wants to merge 2 commits into from
+112 −71

Commits on Jul 8, 2024

  1. Fix Windows line separation. 

    * `BeanOutputConverter` - replace all Windows line separation with \n.
* `BeanOutputConverterTest` - explicitly check line separation using \n.
* Introduce `TextBlockAssertion` that asserts text blocks with line separation set to \n.

(cherry picked from commit e20c9d6)
    @szarpul
    szarpul committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    cc7fd6c View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Fix Windows line separation. 

    * After the fix done in spring-projects#944, the tests were still not passing.
* Following the fix for spring-projects#944, we should compare text blocks against normalized EOL.
* If our goal is to have normalized EOL, then there is no sens to hardcode a `\n` as the target value in `BeanOutputConverterTest.normalizesLineEndingsClassType` test.
    @szarpul
    szarpul committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    2404f07 View commit details
    Browse the repository at this point in the history