Skip to content

Commit

Permalink
Merge branch '3.2.x'
Browse files Browse the repository at this point in the history
Closes gh-41107
  • Loading branch information
philwebb committed Jun 14, 2024
2 parents f961572 + 0c1c7e8 commit bfa541a
Show file tree
Hide file tree
Showing 3 changed files with 55 additions and 3 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2012-2023 the original author or authors.
* Copyright 2012-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -43,7 +43,7 @@ private Method getMainMethod(Thread thread) {
StackTraceElement[] stackTrace = thread.getStackTrace();
for (int i = stackTrace.length - 1; i >= 0; i--) {
StackTraceElement element = stackTrace[i];
if ("main".equals(element.getMethodName())) {
if ("main".equals(element.getMethodName()) && !isLoaderClass(element.getClassName())) {
Method method = getMainMethod(element);
if (method != null) {
return method;
Expand All @@ -53,6 +53,10 @@ private Method getMainMethod(Thread thread) {
throw new IllegalStateException("Unable to find main method");
}

private boolean isLoaderClass(String className) {
return className.startsWith("org.springframework.boot.loader.");
}

private Method getMainMethod(StackTraceElement element) {
try {
Class<?> elementClass = Class.forName(element.getClassName());
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2012-2023 the original author or authors.
* Copyright 2012-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -21,6 +21,7 @@
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;

import org.springframework.boot.loader.launch.FakeJarLauncher;
import org.springframework.util.ReflectionUtils;

import static org.assertj.core.api.Assertions.assertThat;
Expand Down Expand Up @@ -64,6 +65,15 @@ void nestedMainMethod() throws Exception {
assertThat(method.getDeclaringClassName()).isEqualTo(nestedMain.getDeclaringClass().getName());
}

@Test // gh-39733
void vaiJarLauncher() throws Exception {
FakeJarLauncher.action = (args) -> Valid.main(args);
MainMethod method = new TestThread(FakeJarLauncher::main).test();
Method expectedMain = Valid.class.getMethod("main", String[].class);
assertThat(method.getMethod()).isEqualTo(expectedMain);
assertThat(method.getDeclaringClassName()).isEqualTo(expectedMain.getDeclaringClass().getName());
}

@Test
void missingArgsMainMethod() {
assertThatIllegalStateException().isThrownBy(() -> new TestThread(MissingArgs::main).test())
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
/*
* Copyright 2012-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.springframework.boot.loader.launch;

import java.util.function.Consumer;

/**
* Fake launcher in the {@code org.springframework.boot.loader.launch} package used in
* {@code MainMethodTests}.
*
* @author Phillip Webb
*/
public final class FakeJarLauncher {

public static Consumer<String[]> action;

private FakeJarLauncher() {
}

public static void main(String... args) {
action.accept(args);
}

}

0 comments on commit bfa541a

Please sign in to comment.