Deprecate Derby support #48590
Open
Deprecate Derby support #48590
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate Derby support since Apache Derby is retired. Closes spring-projectsgh-48567 Signed-off-by: Philippe Marschall <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
reviewed
Dec 19, 2025
Member
snicoll
left a comment
snicoll
left a comment
There was a problem hiding this comment.
Thanks for the PR, I've made a few comments for your consideration
| * Apache Derby. | ||
| * @deprecated Derby is retired, use HSQLDB or H2 | ||
| */ | ||
| @Deprecated(forRemoval = true, since = "4.1") |
|
|
||
| /** | ||
| * Apache Derby. | ||
| * @deprecated Derby is retired, use HSQLDB or H2 |
Member
There was a problem hiding this comment.
Please look at the other deprecation in the codebase, we use a standard format for this.
| } | ||
|
|
||
| @Test | ||
| @SuppressWarnings("removal") |
Member
There was a problem hiding this comment.
You should flag the test as deprecated instead;
snicoll
added
the
status: waiting-for-feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate Derby support since Apache Derby is retired.
Closes gh-48567
I did no log any warnings when Derby support is used. I'm not aware of such a thing being done anywhere today, let me know if I should add it.
I marked only main code for removal, no tests. I had to add
@SuppressWarningsto main and test code using deprecated Derby code for the build to work.I believe this should go to the 4.1 changelog. I did find a changelog checked in. Are these manually maintained?