-
Notifications
You must be signed in to change notification settings - Fork 41.8k
Add Java8toJava11 #48692
#48694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Java8toJava11 #48692
#48694
Conversation
2d275e7 to
78802af
Compare
Signed-off-by: Vincent Potucek <[email protected]> ``` Changes have been made to build-plugin/spring-boot-gradle-plugin/src/test/java/org/springframework/boot/gradle/tasks/bundling/AbstractBootArchiveIntegrationTests.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to build-plugin/spring-boot-gradle-plugin/src/dockerTest/java/org/springframework/boot/gradle/tasks/bundling/BootBuildImageIntegrationTests.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to build-plugin/spring-boot-maven-plugin/src/main/java/org/springframework/boot/maven/ClassPath.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to build-plugin/spring-boot-maven-plugin/src/test/java/org/springframework/boot/maven/ClassPathTests.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to build-plugin/spring-boot-maven-plugin/src/test/java/org/springframework/boot/maven/CommandLineBuilderTests.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to build-plugin/spring-boot-maven-plugin/src/dockerTest/java/org/springframework/boot/maven/BuildImageTests.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to build-plugin/spring-boot-maven-plugin/src/intTest/java/org/springframework/boot/maven/MavenBuild.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to build-plugin/spring-boot-maven-plugin/src/intTest/java/org/springframework/boot/maven/MavenBuildExtension.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to buildpack/spring-boot-buildpack-platform/src/main/java/org/springframework/boot/buildpack/platform/docker/configuration/ResolvedDockerHost.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to buildpack/spring-boot-buildpack-platform/src/main/java/org/springframework/boot/buildpack/platform/docker/ssl/SslContextFactory.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to buildpack/spring-boot-buildpack-platform/src/main/java/org/springframework/boot/buildpack/platform/build/TarGzipBuildpack.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to buildpack/spring-boot-buildpack-platform/src/main/java/org/springframework/boot/buildpack/platform/build/DirectoryBuildpack.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to buildpack/spring-boot-buildpack-platform/src/main/java/org/springframework/boot/buildpack/platform/build/BuildpackReference.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to buildpack/spring-boot-buildpack-platform/src/main/java/org/springframework/boot/buildpack/platform/socket/NamedPipeSocket.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/docker/configuration/DockerConfigurationMetadataTests.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/docker/configuration/ResolvedDockerHostTests.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/docker/ssl/PemFileWriter.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/docker/transport/LocalHttpClientTransportTests.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/io/FilePermissionsTests.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/build/BuildpackCoordinatesTests.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/build/BuildpackReferenceTests.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/build/TestTarGzip.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to buildpack/spring-boot-buildpack-platform/src/test/java/org/springframework/boot/buildpack/platform/build/DirectoryBuildpackTests.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to cli/spring-boot-cli/src/intTest/java/org/springframework/boot/cli/infrastructure/CommandLineInvoker.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to configuration-metadata/spring-boot-configuration-processor/build.gradle by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.javax.AddCommonAnnotationsDependencies org.openrewrite.java.dependencies.AddDependency: {groupId=jakarta.annotation, artifactId=jakarta.annotation-api, version=1.3.x, onlyIfUsing=javax.annotation..*, scope=provided, acceptTransitive=true} Changes have been made to core/spring-boot/src/main/java/org/springframework/boot/context/config/ConfigTreeConfigDataResource.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to core/spring-boot/src/main/java/org/springframework/boot/system/ApplicationTemp.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to core/spring-boot/src/main/java/org/springframework/boot/SpringApplicationAotProcessor.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to core/spring-boot/src/test/java/org/springframework/boot/context/properties/bind/ValueObjectBinderTests.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to core/spring-boot-autoconfigure-processor/build.gradle by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.javax.AddCommonAnnotationsDependencies org.openrewrite.java.dependencies.AddDependency: {groupId=jakarta.annotation, artifactId=jakarta.annotation-api, version=1.3.x, onlyIfUsing=javax.annotation..*, scope=provided, acceptTransitive=true} Changes have been made to core/spring-boot-docker-compose/src/test/java/org/springframework/boot/docker/compose/lifecycle/DockerComposeLifecycleManagerTests.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to core/spring-boot-test/src/main/java/org/springframework/boot/test/context/SpringBootTestAotProcessor.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to loader/spring-boot-jarmode-tools/src/main/java/org/springframework/boot/jarmode/tools/Context.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to loader/spring-boot-loader/src/main/java/org/springframework/boot/loader/launch/JarFileArchive.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Changes have been made to smoke-test/spring-boot-smoke-test-webservices/build.gradle by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.javax.AddJaxwsDependencies org.openrewrite.java.migrate.javax.AddJaxwsRuntime org.openrewrite.java.migrate.javax.AddJaxwsRuntime$AddJaxwsRuntimeGradle Changes have been made to starter/spring-boot-starter-web-services/build.gradle by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.javax.AddJaxwsDependencies org.openrewrite.java.migrate.javax.AddJaxwsRuntime org.openrewrite.java.migrate.javax.AddJaxwsRuntime$AddJaxwsRuntimeGradle Changes have been made to starter/spring-boot-starter-webservices/build.gradle by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.javax.AddJaxwsDependencies org.openrewrite.java.migrate.javax.AddJaxwsRuntime org.openrewrite.java.migrate.javax.AddJaxwsRuntime$AddJaxwsRuntimeGradle Changes have been made to test-support/spring-boot-test-support/src/main/java/org/springframework/boot/testsupport/classpath/resources/Resources.java by: org.openrewrite.java.migrate.Java8toJava11 org.openrewrite.java.migrate.nio.file.PathsGetToPathOf org.openrewrite.java.ChangeMethodTargetToStatic: {methodPattern=java.nio.file.Paths get(..), fullyQualifiedTargetTypeName=java.nio.file.Path} org.openrewrite.java.ChangeMethodName: {methodPattern=java.nio.file.Path get(..), newMethodName=of} Please review and commit the results. Estimate time saved: 3h 10m BUILD SUCCESSFUL in 8m 35s 842 actionable tasks: 3 executed, 5 from cache, 834 up-to-date ➜ spring-boot git:(fix-EqualityRulesRecipes-pr) ✗ ```
78802af to
4fa0aa2
Compare
|
@Pankraz76 I am not sure I am following what you're doing. We've already mentioned several times we were not interested by such a change at this time. Very recently in #48669. |
|
Yes, I'm sorry—it is related, but it targets a completely different area now. Maybe you're not aware of the capabilities of the tool and the issues I’m referring to. From styling to actual migration, these are things Checkstyle is not capable of and are instead achieved with another tool targeting a different dimension of consistency. This is actually something you are arguing for and doing well. So the arguments align on the principle level, but not on the tooling and priority scope. Nothing for bad this is my last effort so far. |
Add
Java8toJava11#48692