adding fork and begin shuffle text #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. you don't need to clone it down though, you can point kustomize right at the url like the original |
ryanjbaxter
requested changes
Apr 22, 2021
| @@ -2,8 +2,13 @@ | |||
|
|
|||
| * We have a Kustomization that we can use to easily get it up and running | |||
|
|
|||
| Clone the repository for the `kustomization.yaml`. | |||
| ```execute-2 | |||
| git clone https://github.com/springone-tour-2021/docker-services.git | |||
There was a problem hiding this comment.
Like @tybritten said this is not necessary
There was a problem hiding this comment.
In the lab from March we had them clone the original and look at the file I was trying to keep the disect petclinic part that does that and use the files at the same time. We can have them clone the original repo. I was thinking to put the original as a reference for those that want to repeat locally if we go with the fork.
There was a problem hiding this comment.
I think we should just stick to referencing the fork throughout the workshop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.