-
Notifications
You must be signed in to change notification settings - Fork 0
[♻️ Refactor/123] 공통 및 비인증 API fetcher 구현 #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello @chldntjr1321, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 API 호출 로직을 리팩토링하여 기존의 Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
이 PR은 baseFetcher를 coreFetch와 publicFetch로 분리하여 API 호출 로직을 리팩토링했습니다. 코드의 역할 분리가 명확해져 유지보수성이 향상된 점이 좋습니다. 다만, 새로 추가된 coreFetch의 에러 처리 방식, publicFetch의 문서화, 그리고 임시로 주석 처리된 코드들에 대해 몇 가지 개선점을 제안합니다. 아래 리뷰 코멘트를 확인해주세요.
aahreum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰 남겼습니다!! coreFetch 최고네요!! 👍👍👍
aahreum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인했습니다!!!
만들어주신 coreFetch 함수 기반으로 server fetch, bff fetch 작업해보겠습니다!!
감사합니다~!!!
Jihyun0522
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코드 확인하고 리뷰 남깁니다!
구현이 꽤 복잡하고 어려워 보이는데, 정말 고생 많으셨습니다!👍
저도 우석님 코드 다시 보면서 많이 공부해보겠습니다!
✅ PR 체크리스트
1. 코드 & 기능
2. UI
3. 컨벤션
🔗 이슈 번호
✨ 작업한 내용
baseFetcher.ts삭제coreFetch.ts추가 -> 공통 fetcherpublicFetch.ts추가 -> 비인증 api 전용 fetcher💁 리뷰 요청 / 코멘트
💡 참고사항