-
Notifications
You must be signed in to change notification settings - Fork 0
[✨ Feature/128] 로그아웃 API 구현 #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello @aahreum, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 사용자의 로그아웃 기능을 구현하기 위해 새로운 API 엔드포인트를 추가합니다. 이 API는 서버 측에서 HttpOnly 쿠키에 저장된 인증 토큰을 안전하게 제거하여 사용자 세션을 종료하며, 클라이언트 측에서 별도의 토큰 관리 없이 로그아웃을 처리할 수 있도록 합니다. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
로그아웃 API 구현을 위한 PR 잘 보았습니다. BFF (Backend-For-Frontend) 패턴을 사용하여 HttpOnly 쿠키를 서버 측에서 제거하는 방식으로 로그아웃을 구현한 점이 좋습니다. 다만, 호출되는 clearAuthTokens 함수의 쿠키 삭제 로직에 치명적인 버그가 있을 가능성이 있어 확인이 필요하며, 에러 핸들링을 개선할 여지가 있어 몇 가지 리뷰 의견을 남깁니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이전에 쿠키와 관련된 코드를 구현해보지 않아서
아름님이 구현해주신 HttpOnly 쿠키를 통한 토큰 삭제 코드를 보면서 많은 공부가 됐습니다!
|
수정 완료했습니다~!! |
chldntjr1321
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저장된 쿠키를 제거 방식으로 로그아웃 구현하기 잘 보았습니다!! LGTM👍 수고 많으셨습니다😭👏
Jihyun0522
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정 확인했습니다!
HttpOnly 쿠키를 통한 토큰 삭제 코드 잘 보았습니다!
|
확인 감사드립니다~!! 바로 머지하겠습니다~!!! |
✅ PR 체크리스트
1. 코드 & 기능
2. UI
3. 컨벤션
🔗 이슈 번호
✨ 작업한 내용
💁 리뷰 요청 / 코멘트
💡 참고사항