Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MDoc Reader support #22

Merged
merged 12 commits into from
Sep 4, 2024
Merged

Conversation

sbihel
Copy link
Member

@sbihel sbihel commented Jul 29, 2024

Tested against wallet-sdk-kt.

To do:

  • the mdoc used by wallet-sdk-kt results in InvalidIssuerAuthentication, which I believe is due to it being expired -- but it does raise the question of how transparent should the Rust layer be about verification errors (opaque but simple vs transparent but complex)
  • I'm not sure CBUUIDClientCharacteristicConfigurationString needs to be set, it looks like it's set by default
  • wallet-sdk-kt has a few bugs:
  • wallet-sdk-swift has a few bugs:
    • it relies on the ident characteristic to be updated before starting the exchange, but it looks like it should be the state characteristic according to wallet-sdk-kt but it's not clear from the specs
    • the scanner is frozen after cancel is pressed

Depends on:

@Ryanmtate Ryanmtate force-pushed the skit-232-iso-mdl-reader-interface-in-swift branch from 5f34843 to b94d87f Compare August 29, 2024 17:35
@Ryanmtate Ryanmtate force-pushed the skit-232-iso-mdl-reader-interface-in-swift branch from 78b04ea to bb6a966 Compare August 29, 2024 23:40
@sbihel sbihel merged commit 8b80370 into main Sep 4, 2024
1 check passed
@sbihel sbihel deleted the skit-232-iso-mdl-reader-interface-in-swift branch September 4, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants