This repository was archived by the owner on Apr 19, 2024. It is now read-only.
Open
Conversation
There is a discrepancy between $verification_method and $issuer_verification_method. Although I notice in the appendix you use $verification_method. I was also a bit confused by the note: `In these examples, the keys representing the two parties are stored in expressive filenames, 'issuer_key' and 'holder_key'. There are, however, no differences between these keys, and the JWK filenames were chosen simply to clarify the example; there are no restrictions on them.` referring to holder_key when that does not appear in the text. Perhaps would be clearer to refactor to have a holder key and use that did as the id of the credental rather using dummy data for the credential subject. Pretty cool kit though!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a discrepancy between $verification_method and $issuer_verification_method. Although I notice in the appendix you use $verification_method.
I was also a bit confused by the note:
In these examples, the keys representing the two parties are stored in expressive filenames, 'issuer_key' and 'holder_key'. There are, however, no differences between these keys, and the JWK filenames were chosen simply to clarify the example; there are no restrictions on them.referring to holder_key when that does not appear in the text. Perhaps would be clearer to refactor to have a holder key and use that did as the id of the credental rather using dummy data for the credential subject.
Pretty cool kit though!