[WIP] PR: Improve UI to make it more user friendly and fix support for remote environments#28
Draft
ccordoba12 wants to merge 42 commits into
Draft
[WIP] PR: Improve UI to make it more user friendly and fix support for remote environments#28ccordoba12 wants to merge 42 commits into
ccordoba12 wants to merge 42 commits into
Conversation
This is in preparation to make the plugin a SpyderPluginV2 one.
Instead of having a dock widget for the envs manager, we added a menu entry in `Tools > Environment manager` to show it.
Also, add dialog to show SpyderEnvManagerWidget.
- For now this widget only has the header and a couple of lineedits to set the package name to install and its version. - It also sets the right interactions with new_env_widget in EnvManagerDialog.
Also, make that widget inherit from ElementsTable to implement the new design to create envs discussed with the UX team.
Also, disable envs table when deleting an env.
It's derived from NewEnvironment.
Only show input fields and message label there
Also, give focus to the field we want users to start with when creating and importing an env.
ccordoba12
changed the title
--branch=fixes-for-remote-development --update --force external-deps/envs-manager subrepo: subdir: "external-deps/envs-manager" merged: "47231b3" upstream: origin: "https://github.com/ccordoba12/envs-manager.git" branch: "fixes-for-remote-development" commit: "47231b3" git-subrepo: version: "0.4.9" origin: "https://github.com/ingydotnet/git-subrepo" commit: "ea10886"
This name makes more sense according to the way this widget will be embedded in the Remote connections dialog.
ccordoba12
force-pushed
the
improve-ui
branch
2 times, most recently
from
4030bd1 to
751c13c
Compare
ccordoba12
force-pushed
the
improve-ui
branch
3 times, most recently
from
c153890 to
3ef6739
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
==========================================
+ Coverage 74.29% 74.67% +0.37%
==========================================
Files 13 18 +5
Lines 1070 1820 +750
==========================================
+ Hits 795 1359 +564
- Misses 275 461 +186 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ccordoba12
force-pushed
the
improve-ui
branch
from
3ef6739 to
a3033f0
Compare
Also, fix plugin name and remove ellipsis in Tools menu action.
The prevents a possible error with missing or incorrect ssh keys.
ccordoba12
force-pushed
the
improve-ui
branch
from
a3033f0 to
8cec30a
Compare
ccordoba12
force-pushed
the
improve-ui
branch
from
53dee0a to
9482b9c
Compare
ccordoba12
force-pushed
the
improve-ui
branch
2 times, most recently
from
8cfd77a to
fc338f2
Compare
subrepo: subdir: "external-deps/envs-manager" merged: "aaacef7" upstream: origin: "https://github.com/ccordoba12/envs-manager.git" branch: "fixes-for-remote-development" commit: "aaacef7" git-subrepo: version: "0.4.9" origin: "https://github.com/ingydotnet/git-subrepo" commit: "ea10886"
- The format now includes the Python version. - Use that info to display the Python version for each env in ListEnvironments. - Also, send the Python version to the backend when creating and importing an env to be more explicit about it and to be able to display it in ListEnvironments when adding the env to it.
- Now we can't send directly to the server the bytes corresponding to import file because we need to extract the Python version from it first. - Move the necessary code from the plugin to the manager to simplify the implementation.
subrepo: subdir: "external-deps/envs-manager" merged: "859a31a" upstream: origin: "https://github.com/ccordoba12/envs-manager.git" branch: "fixes-for-remote-development" commit: "859a31a" git-subrepo: version: "0.4.9" origin: "https://github.com/ingydotnet/git-subrepo" commit: "ea10886"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.