Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.x backport optional qtwebengine #22196 #22198

Draft
wants to merge 3 commits into
base: 5.x
Choose a base branch
from

Conversation

hmaarrfk
Copy link
Contributor

xref: #22196

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

Mark Harfouche hmaarrfk

@ccordoba12
Copy link
Member

I have a quick question for you: do you think this is really necessary for the 5.x branch? I'm asking it because:

  1. This branch can't and won't work with Qt6 because it doesn't contain any fixes to support it. In addition, it's in maintenance mode now, so no major features will be merged to it. However, master should work with Qt6.
  2. Packages for Qt5 QtWebEngine are available in Conda-forge, so I don't see how this could improve the situation there.

@hmaarrfk
Copy link
Contributor Author

I find that if you are supporting both, fixing "import errors" makes it really difficult to backport future fixes in the long term.

Given I had already done the work, I figured I could do the backport to test.

Honestly, I've been somewhat managing the cf qt-webengine for Qt5, but at one point, it will break.....

We can definitely "delay" since I got this patch in:
conda-forge/conda-forge-repodata-patches-feedstock#782

but yea..... if you want to have an future release of 5.X, this backport would make future backports easier. Whether or not you decide to remove the pyqtwebengine from the conda-forge releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants